[Bug Fix] on-prem TFS missing collections #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirill-ivlev
approved these changes
Mar 26, 2024
|
@kirill-ivlev thanks for approving! Do you know who else can approve to get this PR completed? My customer still runs into this issue occasionally and it would be great to have this in the official release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TfsConnection constructor allows for invalid serviceUrl when using on-prem server. Subsequent commands will report success, even though they fail to do anything.
Testing setup:
On-prem server with a serviceUrl in the following format:
http://www.example.com/tfsPAT token created at the server level ex:
http://www.example.com/tfs/_usersSettings/tokenstfx loginService URL: {http://www.example.com/tfs}it should fail here, because there is no collection path, but it does not
enter
PAT tokenand run a command. for example, this one will incorrectly report success.tfx build tasks upload --task-zip-path {path to task}With this PR, login will correctly fail if no collection path is provided when using on-prem.a